Closed Bug 508793 Opened 15 years ago Closed 15 years ago

[ja] remove lr=lang_ja parameter from google japan search engine

Categories

(Mozilla Localizations :: ja / Japanese, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(2 files, 2 obsolete files)

Current Japanese Google search plug-in contains lr=lang_ja parameter since it was better to have it to get better search results.
http://mxr.mozilla.org/l10n/source/ja/browser/searchplugins/google-jp.xml

It's not so obvious search results with the parameter is better or not but Google Japan's research say that search results without the parameter is better for Japanese users today.
And Google Japan requested us to remove the parameter for better search results.

So, we want/need to remove lr=lang_ja parameter from google-ja.xml.
remove the paremeter
# actually not removed but commented out to make people revert this easy
# if he want to keep using the parameter
Attachment #392928 - Flags: review?(l10n)
I filed this bug since this is search engine related change and we need to update the plugin not only trunk (central) but also 1.9.0 and 1.9.1 branches.
Attachment #392928 - Flags: review?(l10n) → review?(stas)
stas: ping...

I request this change for 1.9.2 branch too.
I wonder if we could just use the generic google.xml plugin from en-US now. It looks like there are no more differences now between google.xml and google-ja.xml except for the URL's template (google.com vs. google.co.jp). But, the plugin should redirect correctly anyways. And, this would be easier for everybody in the future from a maintenance point of view (e.g. updates to the plugin).

Dynamis, what do you think?
Attached patch use default google plug-in (obsolete) — Splinter Review
This is the patch to remove google-jp.xml and just use default global google.xml (same for ja-JP-mac).
Requesting approval to change this for all branches
# 1.9.0, 1.9.1, 1.9.2 and trunk

note:
I'm not 100% sure whether google always redirect correctly from google.com to google.co.jp (since we have had trouble very long time with their redirect bug for iGoogle etc) but I agree it's better to use default one in this case.
Attachment #392928 - Attachment is obsolete: true
Attachment #415101 - Flags: review?(stas)
Attachment #392928 - Flags: review?(stas)
Comment on attachment 415101 [details] [diff] [review]
use default google plug-in

Thanks dynamis. r=me. 

(please "hg rm google-jp.xml" before you land).

Requesting the approval on 1.9.0.x for this.

Please land on 1.9.1, 1.9.2 and central, and opt in with the new revision.
Attachment #415101 - Flags: review?(stas)
Attachment #415101 - Flags: review+
Attachment #415101 - Flags: approval1.9.0.17?
Axel: You normally approve these for 1.9.0. We can, but I'll leave this in your list for now. :)
Summary: remove lr=lang_ja parameter from google japan search engine → [ja] remove lr=lang_ja parameter from google japan search engine
status note:

The patch to remove google-jp.xml have already review granted but initially Google Japan required just to remove the lr=lang_ja param. So currently confirming about this change with Google Japan (and Google Mountain View).

Once it's confirmed, I'll land this to hg repos.
Stats, sorry but when I confirmed with Google Japan, they required different update than first request. Now they require:

 a. remove lr=lang_ja parameter (same as first request)
 b. add hl=ja parameter (new request)
 c. keep using www.google.co.jp host, not www.google.com

As for c, they said redirect from www.google.com to www.google.co.jp isn't always correct. For example if gateway server isn't in their country, they are redirected to other language server depending on the gateway server location.

They requested this change for Fennec too and I'll attach new plug-ins for Firefox and Fennec separately (since icon image are different and can be approved separately in case of some problem).
OS: Mac OS X → All
Hardware: x86 → All
Summary: [ja] remove lr=lang_ja parameter from google japan search engine → [ja] remove lr=lang_ja and add hl=ja parameter for google japan search engine
requesting approval for this new search plugin for Firefox
# for all 1.9.1, 1.9.2 and central branches
Attachment #415101 - Attachment is obsolete: true
Attachment #416683 - Flags: review?(stas)
Attachment #415101 - Flags: approval1.9.0.17?
requesting approval for this new search plugin for Fennec
# of course I'll update list.txt at the same time
Attachment #416684 - Flags: review?(stas)
Dynamis, sorry for asking for more work, but I'm loosing context here. Would you mind filing two new bugs for this in "Mozilla Localizaions > ja", please? One for Firefox's plug-in, second for Fennec. Also, please attach patches, not entire plug-ins. 

I'm reverting to previous summary and closing this bug as fixed. We did fix what the previous summary stated :)

Thanks!
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Summary: [ja] remove lr=lang_ja and add hl=ja parameter for google japan search engine → [ja] remove lr=lang_ja parameter from google japan search engine
Blocks: 534125
Staś, I filed separate bug 534125 for Firefox one and bug 534139 for Fennec one.
No longer blocks: 534125
Attachment #416683 - Flags: review?(stas)
Attachment #416684 - Flags: review?(stas)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: